Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BranchPoint is not JSON serializable #21

Closed
neitzke opened this issue Sep 27, 2015 · 6 comments
Closed

BranchPoint is not JSON serializable #21

neitzke opened this issue Sep 27, 2015 · 6 comments

Comments

@neitzke
Copy link
Collaborator

neitzke commented Sep 27, 2015

Just now I tried a few times to save generated spectral networks; each time I got an error like:

TypeError: <loom.trivialization.BranchPoint instance at 0x7f3f9d634128> is not JSON serializable
chan-y-park added a commit that referenced this issue Oct 4, 2015
@chan-y-park
resolving issue #21
bb4013b
@chan-y-park
Copy link
Owner

Fixed the problem. Note to everyone including myself: every attribute of SWall and Joint should be something that can be directly cast into text to be saved as JSON data. For example, this issue occurred because an instance of BranchPoint was a part of SWall.cuts_intersections.

@neitzke
Copy link
Collaborator Author

neitzke commented Oct 4, 2015

Thanks, Chan, that will be a big help!

@chan-y-park
Copy link
Owner

Reopening this regarding issue #28

@chan-y-park chan-y-park reopened this Oct 14, 2015
@plonghi
Copy link
Collaborator

plonghi commented Oct 14, 2015

Chan, are already at work on this? Otherwise I could take care of it quickly

@chan-y-park
Copy link
Owner

Feel free to work on it — I was not specifically pursuing the issue but was hoping to correct it while I am continuing the work of implementing the web UI and merging the current master into it.

@plonghi
Copy link
Collaborator

plonghi commented Oct 14, 2015

Should work now.

@plonghi plonghi closed this as completed Oct 14, 2015
@plonghi plonghi mentioned this issue Oct 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chan-y-park @plonghi @neitzke