Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Random Image #354

Merged
merged 4 commits into from
Apr 25, 2018
Merged

Get Random Image #354

merged 4 commits into from
Apr 25, 2018

Conversation

JRichlen
Copy link
Contributor

Added chance.image to get random images from Lorem Picsum

@somejeff
Copy link
Contributor

somejeff commented Apr 5, 2018

I like the creative idea of returning random images. I'm concerned with a dependency on a third party site. Maybe renaming the function to chance.loremPicsum(); would alleviate the anxiety?

@victorquinn
Copy link
Member

This is great, thanks @JRichlen for the addition!

@victorquinn victorquinn merged commit b703e28 into chancejs:master Apr 25, 2018
@gbouteiller
Copy link

Hello and thank you for the addition. Shouldn't it be added to the documentation and types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants