📞 Phone number can now be generated for South Africa #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I discovered a little bug in the code. It was already possible to generate random phone numbers for South Africa (
{ country: 'za' }
) but only with{ formatted: false }
. Otherwise the function just returnedtrue
. Here is my proposal to fix it 😉.Additionally I wrote some tests for it and mentioned the
{ country: 'za' }
option in the documentation 👍It's a great lib. Really! Thanks for sharing this with us!!!
Greetings,
Sewas