Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mctp over kcs update #6

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Mctp over kcs update #6

merged 5 commits into from
Oct 16, 2023

Conversation

Kostr
Copy link

@Kostr Kostr commented Oct 5, 2023

No description provided.

@Kostr
ManageabilityPkg: Correct value for the MCTP TAG_OWNER response bit
47b4366 
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
@Kostr
ManageabilityPkg: Don't check MCTP header fields if transfer operaion…
72d10df 
… has failed

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
@Kostr
ManageabilityPkg: Add more check for the MCTP header fields
42e764d 
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
@Kostr
ManageabilityPkg: Use correct constants for PLDM header checks
4e9a77d 
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
@Kostr
Copy link
Author

Kostr commented Oct 5, 2023

Also PLDM code uses additional define that is added here:

changab/edk2#1

@Kostr
ManageabilityPkg: Return error on multiple-packet MCTP responses
3f09309 
Since the current driver doesn't yet support handling of
multiple-packet MCTP responses, return EFI_UNSUPPORTED error in such
cases.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
@Kostr
Copy link
Author

Kostr commented Oct 6, 2023 •
edited

I've added a commit that returns an error if the destination EID responds with a multi-packets MCTP, since currently this case is not handled by the driver code.

But in the end we would need to utilize these fields in a similar way that we do when we send the MCTP request:

MctpTransportHeader->Bits.PacketSequence
MctpTransportHeader->Bits.StartOfMessage
MctpTransportHeader->Bits.EndOfMessage

changab
changab approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@changab changab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

@changab changab merged commit 2010f77 into changab:MCTP_OVER_KCS_UPDATE Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changab changab changab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Kostr @changab