feat: set pullRequestNumber as action output #167
Conversation
🦋 Changeset detectedLatest commit: 0db863f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| script: getOptionalInput("version"), | ||
| githubToken, | ||
| prTitle: getOptionalInput("title"), | ||
| commitMessage: getOptionalInput("commit"), | ||
| hasPublishScript, | ||
| }); | ||
|
|
||
| core.setOutput("pullRequestNumber", String(pullRequestNumber)); |
There was a problem hiding this comment.
Since this will always be int - could we not cast it with String()? Would it have any observable difference if this wouldn't be casted? Like perhaps one version would not be quoted or smth? Did you test this from the consumer's side of this action?
I've checked the source code of @actions/core and I think this gets stringified anyway but it would be great if we could confirm if there is any practical difference between both flavours - if there is not then I'm ok with leaving it as is.
There was a problem hiding this comment.
Actually, I've just checked this locally and both are equivalent:
There was a problem hiding this comment.
I did it for a couple reasons:
- like you said, it's always coerced into a string under the hood and I think everything needs to be a string
- to control the type of output to make it consistent, regardless of what actions does under the hood
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Closes: #82