Fix for #338 - Handle unpublished packages on github package registry (…

…#469) * handle non-existant packages on github pkg registry * add changeset * resolve prettier issues Co-authored-by: Ben Conolly <ben@thinkmill.com.au>
changesets · Nov 23, 2020 · c6d38b5 · c6d38b5
1 parent 3ab2adc
commit c6d38b5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/.changeset/tame-snails-change.md b/.changeset/tame-snails-change.md
@@ -0,0 +1,5 @@
+---
+"@changesets/cli": minor
+---
+
+Handle JSON errors for unpublished packages on the github package registry
diff --git a/packages/cli/src/commands/publish/npm-utils.ts b/packages/cli/src/commands/publish/npm-utils.ts
@@ -86,6 +86,15 @@ export function getPackageInfo(pkgName: string) {
       env: Object.assign({}, process.env, envOverride)
     });
 
+    // Github package registry returns empty string when calling npm info
+    // for a non-existant package instead of a E404
+    if (result.stdout.toString() === "") {
+      return {
+        error: {
+          code: "E404"
+        }
+      };
+    }
     return jsonParse(result.stdout.toString());
   });
 }