Fix for #338 - Handle unpublished packages on github package registry #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac7e8da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hooray! All contributors have signed the CLA. |
Noviny
approved these changes
Nov 23, 2020
|
Thanks for this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing the issue referenced in #338.
When running
npm info pkgName --jsonNPM returns the 'E404' JSON response the code is expecting. If the registry target is the Github package registry, the samenpm infocommand returns just an empty string.https://github.com/atlassian/changesets/blob/d570a24740a374a9547dd7d931e6ac854e36a9fb/packages/cli/src/commands/publish/npm-utils.ts#L61
This code errors b/c it tries to parse an empty string. This PR just returns an error object similar to what NPM returns so that the publish command just sees it as an unpublished package.
I'm not super familiar with this repo, but this solution could be improved by checking the registry and only allowing empty responses to count as 404 for github packages. Unsure how to do that here.