Do not check if a 2FA token is required when on other registries #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 51db063 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
=====================================
Coverage 80% 80%
=====================================
Files 45 45
Lines 1220 1220
Branches 284 280 -4
=====================================
Hits 976 976
Misses 233 233
Partials 11 11
Continue to review full report at Codecov.
|
Noviny
approved these changes
Mar 5, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #247
Closes #287
The approach I've taken here is "if the registry isn't the npm registry or npm profile get fails, assume we don't need 2fa". Note that if the isRequired thing returns false but then a publish fails because of 2fa, we'll prompt for a token. npm profile get is purely an optimisation to make publishes faster.