Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Changes not detected by changeset cli 2.23.1 #871

Merged
merged 2 commits into from Jul 13, 2022

Conversation

NicoKam
Copy link
Contributor

@NicoKam NicoKam commented Jul 13, 2022

Not include ignore.

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

🦋 Changeset detected

Latest commit: e34da75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e34da75:

Sandbox Source
Vanilla Configuration

@NicoKam NicoKam marked this pull request as ready for review Jul 13, 2022
@@ -42,7 +42,7 @@ export default async function add(
});
const changePackagesName = changedPackages
.map(pkg => pkg.packageJson.name)
.filter(pkgName => config.ignore.includes(pkgName));
.filter(pkgName => !config.ignore.includes(pkgName));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why

Copy link
Member

@Andarist Andarist Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch 😬 sorry for that!

@@ -42,7 +42,7 @@ export default async function add(
});
const changePackagesName = changedPackages
.map(pkg => pkg.packageJson.name)
.filter(pkgName => config.ignore.includes(pkgName));
.filter(pkgName => !config.ignore.includes(pkgName));

newChangeset = await createChangeset(changePackagesName, packages);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line correct? Could you check this as well?

Because I got an error below

$ /Users/ms.park/Desktop/workspace/payment.ohou.se/node_modules/.bin/changeset
🦋  error TypeError: Cannot read properties of undefined (reading 'packageJson')
🦋  error     at createChangeset (/Users/ms.park/Desktop/workspace/payment.ohou.se/node_modules/@changesets/cli/dist/cli.cjs.dev.js:415:75)
🦋  error     at add (/Users/ms.park/Desktop/workspace/payment.ohou.se/node_modules/@changesets/cli/dist/cli.cjs.dev.js:507:26)
🦋  error     at async run$2 (/Users/ms.park/Desktop/workspace/payment.ohou.se/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1254:5)
error Command failed with exit code 1.

And this error is from this line.

This line was originally same with before

    newChangeset = await createChangeset(changePackagesName, packages.packages);

But this had been changed since 2.23.1

Copy link
Member

@Andarist Andarist Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With what version do you experience this problem? With the 2.23.1 or with the version of the code from this PR?

@Andarist Andarist merged commit e174172 into changesets:main Jul 13, 2022
4 checks passed
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants