-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Changes not detected by changeset cli 2.23.1 #871
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@changesets/cli": patch | ||
--- | ||
|
||
Fixed filtering of the ignored packages when adding a changeset. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,7 @@ export default async function add( | |
}); | ||
const changePackagesName = changedPackages | ||
.map(pkg => pkg.packageJson.name) | ||
.filter(pkgName => config.ignore.includes(pkgName)); | ||
.filter(pkgName => !config.ignore.includes(pkgName)); | ||
|
||
newChangeset = await createChangeset(changePackagesName, packages); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this line correct? Could you check this as well? Because I got an error below
And this error is from this line. This line was originally same with before
But this had been changed since 2.23.1 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With what version do you experience this problem? With the 2.23.1 or with the version of the code from this PR? |
||
printConfirmationMessage(newChangeset, packages.length > 1); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch 😬 sorry for that!