-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert more things to TS #91
Conversation
🦋 Changeset is good to goLatest commit: 4923a32 We got this. Not sure what this means? Click here to learn what changesets are. |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 83.2% 83.23% +0.02%
==========================================
Files 31 31
Lines 810 811 +1
Branches 145 144 -1
==========================================
+ Hits 674 675 +1
Misses 125 125
Partials 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ell Gee Tee Emm
export default function versionRangeToRangeType(versionRange) { | ||
export default function versionRangeToRangeType( | ||
versionRange: string | ||
): "^" | "~" | "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated question: we talk about rangeType here, BUT we only support 3 of the [many] types. This hasn't burned us so far, but probably will at some point? Is it worth us trying to proactively fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to improve it but we physically can't handle every case and other types generally aren't used that often so it's probably not something we should spend much time on.
The package.json file will be updated to reflect the latest version range. By default, the existing range specifier in package.json will be reused if it is one of: ^, ~, <=, >, or an exact version. Otherwise, it will be changed to a caret (^).
I think if we had the same behavior as yarn, that would probably work well.
* More things to TS * Add changesets
Mostly things from #83