not merge this is a proposal

[JuanVqz]

I think the idea of keeping everything in a view is very good because
it is more user friendly, however it is difficult to do tests,
I think it would be better to design, follow the CRUD convention.

I mention it to continue doing the tests

what do you think?

[changeweb]

👏 👏 PR Review 👏 👏
I like your approach. But there are some things that need to be changed a bit.

I won't be able to give time to this project tomorrow since I'll be a bit busy. I'll discuss it here as soon as I can. Be patient and thanks for your time and help that you are contributing so generously 👏 .

[anishojha]

Yes we have to follow CRUD convention, it will make the code more readable, but all these will do a major change in, so it's the perfect time to do this.
Once we are in stable mode, these type of major changes will be a bit tedious.

[changeweb]

I will create a new dev branch to push any new changes before merging on Master branch.

We need to follow 1 step at a time for this big refactoring. What do you think?

[JuanVqz]

@changeweb yes it's the perfect way. step at a time, what would you think is the easiest first step?

[changeweb]

We should do something like this:
Make all changes for a page. Example: Update everything with the change we want. Like:

1. Edit url in a single page views and Form method to reflect CRUD.
2. Update the url with the edited url in page views in routes/web.php with new route name e.g.: resource() to reflect CRUD.
3. Update associated controller methods with the CRUD.
4. Write Feature test for the page.

[JuanVqz]

@changeweb today I have time if you can create a new branch, I'll start like you told.

[changeweb]

@JuanVqz ok I'm creating one

[changeweb]

@JuanVqz dev_for_new_features branch is created.

[JuanVqz]

@changeweb sorry for many problems.

We should set the format of the name of the style attributes, I think it's easier to read with the case of the snake, for example, rowNo to row_no
We should use route than url helper

I think we can follow this guide

or maybe all guide naming conventions

I don't like this format maybe only in classes it's good.

public function foo()
{
  //
}

I'm like this format

public function foo() {
  //
}

but you should set the format...

[changeweb]

I try to use snake case for variable name and camel case for function name.
I also prefer 2nd format you liked. But some of the code are in 1st format because they were auto generated.

Some variable names got camel cased because I read an article about snake case vs camel case and wanted to see how it looks when implemented. But I got lazy to update them later. Sorry.

[anishojha]

@JuanVqz @changeweb

Laravel follows the PSR-2 coding standard and the PSR-4 autoloading standard.
Check this link Laravel Coding Style

These are PHP Coding Standard, so we should stick to them

[Soneji]

sorry typo. I meant to reference 192 not 92