suggestions for #85 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This indicates that `Display` values are essentially being recorded as strings, rather than structured data, in the `Debug` output. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
chanks
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes a few changes I suggested to PR tokio-rs#85.
This includes:
From<&'a dyn Display>impl forValueValue::as_displayto return aDisplaytrait objectfor all primitive
Valuetypes that implementDisplay, ratherthan only for
dyn Displayvaluesdyn Displayvalues inValue'sDebugimplto more clearly indicate that they are essentially a form of string
Value::Displayinvaluable-serde@chanks, please let me know what you think of these suggestions
and feel free to merge my PR into your branch for tokio-rs#85 if you like!