-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using --single-branch in tests #155
Conversation
... by making sure that the local repository is cloned at the right time. The --single-branch argument does a bit more than just ordering git to clone only the given branch, but actually changes the way the repository is tracked so that only the given (master) branch is tracked. This makes it so that tests behave differently from the actual running app, notably when dealing with parallel and speculative builds as in #77. This change makes it so that tests and running code are more similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of questions. Some things weren't that clear to me. Other than that, I won't be standing in the way of progress 😄
@marcin-rzeznicki Thanks for the review. I believe to have addressed your comments (with changes in the comments). Can you please review again? 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! LGTM
@marcin-rzeznicki Awesome. Thanks again for the review. @OpsBotPrime merge |
Pull request approved for merge by @rudymatela, rebasing now. |
Approved-by: rudymatela Auto-deploy: false
Rebased as 4873ebe, waiting for CI … |
CI job started. |
Avoid using
--single-branch
in tests by making sure that the local repository is cloned at the right time.The
--single-branch
argument does a bit more than just ordering git to clone only the given branch, but actually changes the way the repository is tracked so that only the given (master) branch is tracked. This makes it so that tests behave differently from the actual running app, notably when dealing with parallel and speculative builds as in #77.This change makes it so that tests and running code are more similar.
This is needed for #137.