Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only wait in durable request if enqueuing was successful #45

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Only wait in durable request if enqueuing was successful #45

merged 1 commit into from
Nov 9, 2018

Conversation

fatho
Copy link
Member

@fatho fatho commented Nov 9, 2018

Fixes #39.

@fatho fatho requested a review from rkrzr November 9, 2018 10:28
rkrzr
rkrzr approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@rkrzr rkrzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This then forces the client to handle retries if enqueuing fails, but that's a good choice, I think.

@fatho fatho merged commit 40c0b94 into master Nov 9, 2018
@fatho fatho deleted the fix/wait-bug branch November 9, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrzr rkrzr rkrzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fatho @rkrzr