Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Required: Fix Renovate Configuration #1217

Closed
renovate bot opened this issue Mar 20, 2023 · 2 comments · Fixed by #1218, #1219 or #2404
Closed

Action Required: Fix Renovate Configuration #1217

renovate bot opened this issue Mar 20, 2023 · 2 comments · Fixed by #1218, #1219 or #2404
Assignees

Comments

@renovate
Copy link
Contributor

renovate bot commented Mar 20, 2023

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: renovate.json
Error type: The renovate configuration file contains some invalid settings
Message: Invalid schedule: Invalid schedule: "0 10-19 1-7 * MON" has cron syntax, but doesn't have * as minutes

@sungik-choi
Copy link
Contributor

@yangwooseong

Copy link

channeltalk bot commented Aug 2, 2024

@yangwooseong yangwooseong self-assigned this Aug 2, 2024
@renovate renovate bot reopened this Aug 2, 2024
yangwooseong added a commit that referenced this issue Aug 5, 2024
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->
- #1217


## Summary

<!-- Please brief explanation of the changes made -->

- renovate schedule에서 minute을 * 으로 변경합니다. 

## Details

<!-- Please elaborate description of the changes -->

- 위 이슈에서 `Invalid schedule: "0 10-19 1-7 * MON" has cron syntax, but
doesn't have * as minutes` 에러를 뱉고 있습니다.

소스를 뒤져보면 


```tsx
      if (
        parsedCron.fields.minute.length !== 60 ||
        scheduleText.indexOf(minutesChar) !== 0 // (const minutesChar = "*")
      ) {
        message = `Invalid schedule: "${scheduleText}" has cron syntax, but doesn't have * as minutes`;
        return true;
      }
```

cron syntax에서는 minute 이 * 이어야 하는 것 같습니다. 

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

- No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

-
https://github.com/renovatebot/renovate/blob/64b0555ce303f83a566765a0fa092a1ea4c22a48/lib/workers/repository/update/branch/schedule.ts#L61-L67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants