Enhance build time for bezier-react #1424
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| node_modules | ||
| dist | ||
| coverage | ||
| __mocks__ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,20 @@ | ||
| module.exports = { | ||
| presets: [ | ||
| ['@babel/preset-env', { useBuiltIns: 'entry', corejs: '3.31.0', bugfixes: true }], | ||
| /** | ||
| * Will use the native built-in instead of trying to polyfill behavior for any plugins that require one. | ||
| * Remove the helper function for Object.assign. | ||
| * @see https://babeljs.io/docs/babel-preset-react#usebuiltins | ||
| */ | ||
| ['@babel/preset-react', { useBuiltIns: true }], | ||
| ['@babel/preset-typescript', { isTSX: true, allExtensions: true }], | ||
| ], | ||
| plugins: [ | ||
| '@babel/plugin-transform-runtime', | ||
| ['babel-plugin-styled-components', { | ||
| minify: true, | ||
| pure: true, | ||
| topLevelImportPaths: ['~/src/foundation'], | ||
| }], | ||
| ], | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,16 +7,26 @@ | |
| "url": "https://github.com/channel-io/bezier-react", | ||
| "directory": "packages/bezier-react" | ||
| }, | ||
| "main": "dist/cjs/index.js", | ||
| "module": "dist/esm/index.mjs", | ||
|
There was a problem hiding this comment.
|
||
| "types": "dist/types/index.d.ts", | ||
| "exports": { | ||
| ".": { | ||
| "types": "./dist/types/index.d.ts", | ||
| "require": "./dist/cjs/index.js", | ||
| "import": "./dist/esm/index.mjs" | ||
| } | ||
| }, | ||
| "sideEffects": false, | ||
| "files": [ | ||
| "dist", | ||
| "!dist/*.tsbuildinfo", | ||
|
There was a problem hiding this comment. dist 내부에 포함되어있는 ts build log는 파일에 포함하지 않습니다. |
||
| "src" | ||
| ], | ||
| "scripts": { | ||
| "build": "run-p 'build:*'", | ||
|
There was a problem hiding this comment. rollup을 통한 자바스크립트 번들링, ttsc(ttypescript)를 통한 타입 생성을 병렬로 수행합니다. |
||
| "build:js": "rollup -c", | ||
| "build:types": "ttsc --build --verbose ./tsconfig.build.json", | ||
| "dev": "yarn storybook", | ||
| "lint": "run-p 'lint:*'", | ||
| "lint:js": "TIMING=1 eslint --cache .", | ||
|
|
@@ -28,7 +38,7 @@ | |
| "test:watch": "jest --watch", | ||
| "update-snapshot": "jest --updateSnapshot", | ||
| "clean": "run-s 'clean:*'", | ||
| "clean:build": "rm -rf dist", | ||
| "clean:cache": "rm -rf node_modules .turbo .eslintcache .stylelintcache tsconfig.tsbuildinfo coverage", | ||
| "prebuild": "yarn clean:build", | ||
| "storybook": "start-storybook -p 4101", | ||
|
|
@@ -49,18 +59,20 @@ | |
| "not ie <= 11" | ||
| ], | ||
| "devDependencies": { | ||
| "@babel/core": "^7.22.5", | ||
| "@babel/plugin-transform-runtime": "^7.22.5", | ||
| "@babel/preset-env": "^7.22.5", | ||
| "@babel/preset-react": "^7.22.5", | ||
| "@babel/preset-typescript": "^7.22.5", | ||
| "@channel.io/bezier-icons": "^0.2.0", | ||
| "@channel.io/react-docgen-typescript-plugin": "^1.0.0", | ||
| "@mdx-js/react": "^1.6.22", | ||
| "@rollup/plugin-alias": "^5.0.0", | ||
| "@rollup/plugin-babel": "^6.0.3", | ||
| "@rollup/plugin-commonjs": "^25.0.1", | ||
| "@rollup/plugin-node-resolve": "^15.1.0", | ||
| "@rollup/plugin-typescript": "^11.1.1", | ||
| "@rollup/plugin-url": "^8.0.1", | ||
| "@storybook/addon-a11y": "^6.5.0", | ||
| "@storybook/addon-actions": "^6.5.13", | ||
| "@storybook/addon-backgrounds": "^6.5.13", | ||
|
|
@@ -81,13 +93,11 @@ | |
| "@types/react-dom": "^18.0.3", | ||
| "@types/styled-components": "^5.1.5", | ||
| "@types/uuid": "^9.0.0", | ||
| "babel-loader": "^9.1.2", | ||
| "babel-plugin-styled-components": "^2.1.3", | ||
| "babel-preset-react-app": "^10.0.1", | ||
| "chromatic": "^6.11.4", | ||
| "core-js": "^3.31.0", | ||
| "eslint-config-bezier": "workspace:*", | ||
| "eslint-plugin-storybook": "^0.6.0", | ||
| "identity-obj-proxy": "^3.0.0", | ||
|
|
@@ -97,26 +107,29 @@ | |
| "react": "^18.1.0", | ||
| "react-dom": "^18.1.0", | ||
| "regenerator-runtime": "^0.13.11", | ||
| "rollup": "^3.25.1", | ||
| "rollup-plugin-node-externals": "^6.1.1", | ||
| "rollup-plugin-visualizer": "^5.9.2", | ||
| "styled-components": "^5.3.5", | ||
| "ts-prune": "^0.10.3", | ||
| "tsconfig": "workspace:*", | ||
| "tsconfig-paths-webpack-plugin": "^3.5.2", | ||
| "ttypescript": "^1.5.15", | ||
| "typescript-transform-paths": "^3.4.6" | ||
| }, | ||
| "peerDependencies": { | ||
| "@channel.io/bezier-icons": ">=0.2.0", | ||
| "react": "^16.8.0 || ^17.0.0 || ^18.0.0", | ||
| "react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0", | ||
| "styled-components": ">=5" | ||
| }, | ||
| "peerDependenciesMeta": { | ||
| "@channel.io/bezier-icons": { | ||
| "optional": true | ||
| } | ||
| }, | ||
|
Comment on lines
120
to
+130
There was a problem hiding this comment. Why move bezier-icons from deps to peerDeps
|
||
| "dependencies": { | ||
| "@babel/runtime": "^7.22.5", | ||
| "@radix-ui/react-checkbox": "^1.0.3", | ||
| "@radix-ui/react-dialog": "^1.0.2", | ||
| "@radix-ui/react-radio-group": "^1.1.0", | ||
|
|
@@ -129,9 +142,8 @@ | |
| "@radix-ui/react-visually-hidden": "^1.0.2", | ||
| "classnames": "^2.3.2", | ||
| "react-resize-detector": "^7.1.1", | ||
| "react-textarea-autosize": "^8.4.1", | ||
| "ssr-window": "^3.0.0", | ||
| "uuid": "^9.0.0" | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@babel/plugin-proposal-private-property-in-object,@babel/plugin-proposal-class-properties플러그인은preset-envES2022에 내장되었으므로 제거