Storybook 6.4 support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuth
force-pushed
the
storybook-6.4
branch
4 times, most recently
from
369431e
to
1f8325a
Compare
Closed
ahuth
force-pushed
the
storybook-6.4
branch
2 times, most recently
from
af56fe7
to
4e6f590
Compare
This is the downside to relying on Storybook's internal APIs... non-breaking updates can break how axe-storybook-testing works. I still think it's worth it, though. It's the best, easiest, and most performant way I could come up with to actually render and iterate through all the stories in a storybook.
So that they do not ignore legit typescript errors.
Wait until a story has truly "completed" rendering, which we can see at https://github.com/storybookjs/storybook/blob/06bf39e29b517650b303c1f4fa4fbf2697ad3ce1/lib/preview-web/src/PreviewWeb.tsx#L604. The main use case for this is waiting for the new "play" functions to be finished before starting the axe checks.
ahuth
force-pushed
the
storybook-6.4
branch
4 times, most recently
from
1f1a9f1
to
013cbee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to work with Storybook 6.4. Fixes #42.