Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 6.4 support #46

Merged
merged 9 commits into from
Nov 29, 2021
Merged

Storybook 6.4 support #46

merged 9 commits into from
Nov 29, 2021

Commits on Nov 24, 2021

  1. Configuration menu
    Copy the full SHA
    c00aa29 View commit details
    Browse the repository at this point in the history
  2. Update StorybookPage to work with Storybook@6.4

    This is the downside to relying on Storybook's internal APIs... non-breaking updates can break how axe-storybook-testing works.
    
    I still think it's worth it, though. It's the best, easiest, and most performant way I could come up with to actually render and iterate through all the stories in a storybook.
    ahuth committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    9aec002 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e3495fa View commit details
    Browse the repository at this point in the history
  4. Remove @ts-ignore from StorybookPage

    So that they do not ignore legit typescript errors.
    ahuth committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    bf7a749 View commit details
    Browse the repository at this point in the history
  5. Make error message more helpful

    ahuth committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    dc5d3fe View commit details
    Browse the repository at this point in the history
  6. Convert demo examples to CSF v3

    ahuth committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    ad5a7cf View commit details
    Browse the repository at this point in the history
  7. Wait for a story to be officially rendered before running axe

    Wait until a story has truly "completed" rendering, which we can see at https://github.com/storybookjs/storybook/blob/06bf39e29b517650b303c1f4fa4fbf2697ad3ce1/lib/preview-web/src/PreviewWeb.tsx#L604.
    
    The main use case for this is waiting for the new "play" functions to be finished before starting the axe checks.
    ahuth committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    0c2b2b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Configuration menu
    Copy the full SHA
    d126585 View commit details
    Browse the repository at this point in the history
  2. Update Storybook to v6.4.0

    ahuth committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    33601a2 View commit details
    Browse the repository at this point in the history