-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook 6.4 support #46
Merged
Merged
Commits on Nov 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c00aa29 - Browse repository at this point
Copy the full SHA c00aa29View commit details -
Update StorybookPage to work with Storybook@6.4
This is the downside to relying on Storybook's internal APIs... non-breaking updates can break how axe-storybook-testing works. I still think it's worth it, though. It's the best, easiest, and most performant way I could come up with to actually render and iterate through all the stories in a storybook.
Configuration menu - View commit details
-
Copy full SHA for 9aec002 - Browse repository at this point
Copy the full SHA 9aec002View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3495fa - Browse repository at this point
Copy the full SHA e3495faView commit details -
Remove @ts-ignore from StorybookPage
So that they do not ignore legit typescript errors.
Configuration menu - View commit details
-
Copy full SHA for bf7a749 - Browse repository at this point
Copy the full SHA bf7a749View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc5d3fe - Browse repository at this point
Copy the full SHA dc5d3feView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad5a7cf - Browse repository at this point
Copy the full SHA ad5a7cfView commit details -
Wait for a story to be officially rendered before running axe
Wait until a story has truly "completed" rendering, which we can see at https://github.com/storybookjs/storybook/blob/06bf39e29b517650b303c1f4fa4fbf2697ad3ce1/lib/preview-web/src/PreviewWeb.tsx#L604. The main use case for this is waiting for the new "play" functions to be finished before starting the axe checks.
Configuration menu - View commit details
-
Copy full SHA for 0c2b2b1 - Browse repository at this point
Copy the full SHA 0c2b2b1View commit details
Commits on Nov 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d126585 - Browse repository at this point
Copy the full SHA d126585View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33601a2 - Browse repository at this point
Copy the full SHA 33601a2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.