-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify column_names argument in get_anndata() method #1035
Comments
Currently this argument is passed right through to Should this change be made over there? I think it would be odd if the argument |
Emanuele suggested @aaronwolen may have thoughts on whether a change in somacore is on the table here. Personally, I'm not sure this change is worth creating inconsistency between the APIs. But do like this change overall. |
@ivirshup @ebezzi @pablo-gar - I think this is a tricky design issue and the following are my thoughts. I would like to hear your views on this: It seems rather confusing to me that we would allow I would suggest we keep the function signature of Here is why: I think we should distinguish between the public interface of For example, a census API method could wrap several You could imagine other applications built on top of The fact that I think we should avoid doing things like the above where we support both In general, I think we should put more weight on on what makes usage of the |
I have update that code slightly so that now it either errors or throws a warning if I think that argument is fair, but I guess I assumed there was some desire for users to access tiledbsoma for more complex use cases. Then it would be nice for them if the APIs are the same. It could also ease maintenance if the APIs don't drift much and many arguments can be passed straight through. |
Separate the
get_anndata()
methodcolumn_names
argument intoobs_column_names
andvar_column_names
which accept an array instead of an object.Current
Proposed
edited by Pablo
The text was updated successfully, but these errors were encountered: