Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Pass in the full context to open_experiment in pytorch loaders #1108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Apr 24, 2024

Necessary to train pytorch loaders on a private bucket.

Copy link

This PR has not seen any activity in the past 4 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the Stale label May 23, 2024
@prathapsridharan
Copy link
Contributor

@ebezzi - Is this still needed?

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (39a5d1d) to head (6ec4496).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   91.16%   91.12%   -0.05%     
==========================================
  Files          77       77              
  Lines        5896     5891       -5     
==========================================
- Hits         5375     5368       -7     
- Misses        521      523       +2     
Flag Coverage Δ
unittests 91.12% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants