Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding button to lower left, cell selection #1658

Merged
merged 9 commits into from Jul 22, 2020

Conversation

colinmegill
Copy link
Contributor

@colinmegill colinmegill commented Jul 21, 2020

image

partial solution to #1650

@colinmegill colinmegill changed the title Embedding button to lower left, cell selection [WIP] Embedding button to lower left, cell selection Jul 21, 2020
@colinmegill colinmegill marked this pull request as draft July 21, 2020 22:44
@colinmegill colinmegill changed the title [WIP] Embedding button to lower left, cell selection Embedding button to lower left, cell selection Jul 21, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #1658 into main will increase coverage by 5.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   62.18%   68.02%   +5.83%     
==========================================
  Files          36      116      +80     
  Lines        3721    10072    +6351     
  Branches        0      463     +463     
==========================================
+ Hits         2314     6851    +4537     
- Misses       1407     3159    +1752     
- Partials        0       62      +62     
Flag Coverage Δ
#frontend 71.43% <ø> (?)
#javascript 71.43% <ø> (?)
#smokeTestAnnotations 100.00% <ø> (?)
#unitTest 71.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/src/util/stateManager/schemaHelpers.js 72.34% <0.00%> (ø)
server/common/app_config.py 73.24% <0.00%> (ø)
client/src/util/nameCreators.js 100.00% <0.00%> (ø)
client/src/util/dataframe/histogram.js 91.42% <0.00%> (ø)
client/src/annoMatrix/loader.js 94.33% <0.00%> (ø)
client/src/util/fromEntries.js 100.00% <0.00%> (ø)
...nt/__tests__/util/annoMatrix/serverMocks/routes.js 88.37% <0.00%> (ø)
client/src/reducers/undoable.js 70.23% <0.00%> (ø)
server/converters/cxgtool.py 82.97% <0.00%> (ø)
server/data_common/fbs/matrix.py 91.33% <0.00%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009fa2f...34f6418. Read the comment docs.

@bkmartinjr bkmartinjr added this to the Milestone 1: Schema milestone Jul 22, 2020
@bkmartinjr bkmartinjr marked this pull request as ready for review July 22, 2020 22:46
Copy link
Contributor

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinmegill colinmegill merged commit 03bad04 into main Jul 22, 2020
@colinmegill colinmegill deleted the colinmegill/reembed-ui branch July 22, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants