Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subset embedding UI improvement #1667

Merged
merged 6 commits into from Jul 27, 2020
Merged

Conversation

bkmartinjr
Copy link
Contributor

@bkmartinjr bkmartinjr commented Jul 23, 2020

This builds upon #1631 and #1658.

Improved UI for embeddings that include only a subset of all cells. Specifically:

As part of doing this, the view stack semantics are also cleaned up and the code DRY'ed.

Fixes #1559
Fixes #1650

@bkmartinjr bkmartinjr marked this pull request as draft July 23, 2020 20:08
@bkmartinjr bkmartinjr added this to the Milestone 1: Schema milestone Jul 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #1667 into main will increase coverage by 0.38%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
+ Coverage   68.02%   68.40%   +0.38%     
==========================================
  Files         116      116              
  Lines       10072    10079       +7     
  Branches      463      462       -1     
==========================================
+ Hits         6851     6895      +44     
+ Misses       3159     3122      -37     
  Partials       62       62              
Flag Coverage Δ
#frontend 71.76% <66.66%> (+0.32%) ⬆️
#javascript 71.76% <66.66%> (+0.32%) ⬆️
#unitTest 71.76% <66.66%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/src/annoMatrix/viewCreators.js 75.00% <50.00%> (-5.00%) ⬇️
client/src/annoMatrix/annoMatrix.js 67.32% <100.00%> (+0.32%) ⬆️
common/app_config.py 73.29% <0.00%> (+0.05%) ⬆️
server/common/app_config.py 73.29% <0.00%> (+0.05%) ⬆️
client/src/annoMatrix/loader.js 94.39% <0.00%> (+0.05%) ⬆️
client/src/util/stateManager/controlsHelpers.js 43.47% <0.00%> (+1.25%) ⬆️
data_anndata/anndata_adaptor.py 83.17% <0.00%> (+3.36%) ⬆️
server/data_anndata/anndata_adaptor.py 83.17% <0.00%> (+3.36%) ⬆️
client/src/annoMatrix/schema.js 77.77% <0.00%> (+3.49%) ⬆️
client/src/util/catLabelSort.js 94.73% <0.00%> (+5.26%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03bad04...b18dc33. Read the comment docs.

@bkmartinjr bkmartinjr marked this pull request as ready for review July 26, 2020 19:57
@bkmartinjr bkmartinjr merged commit 0a62653 into main Jul 27, 2020
@bkmartinjr bkmartinjr deleted the bkmartinjr/1559-embedding-subsetting branch July 27, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants