docs: updating readme and display version for rebranding #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrosejcarr
approved these changes
Aug 4, 2022
ambrosejcarr
requested changes
Aug 4, 2022
There was a problem hiding this comment.
Currently the browser tab shows as:
For CZ CELLxGENE Annotate, I'd like the browser icon to read:
[NEW pink cellxgene logo] CELLxGENE | Annotate
This will establish a visual distinction from Discover applications but keep the look & feel consistent across our applications.
seve
reviewed
Aug 4, 2022
- CELLxGENE -> CELLxGENE Annotate - reverting __init__.py display_version back to "cellxgene"
|
Made the changes per comments above |
seve
reviewed
Aug 9, 2022
seve
approved these changes
Aug 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #2550 +/- ##
=======================================
Coverage 71.60% 71.60%
=======================================
Files 96 96
Lines 6652 6652
Branches 770 770
=======================================
Hits 4763 4763
Misses 1813 1813
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Alec was able to figure out the unit tests issue so this PR is now merged! |
|
Ready for staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#309
Reviewers
Functional: @seve
Readability: @seve @karenliang0
Changes
Updating Readme and init.py