Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating Annotate favicon and logo icon #2556

Merged
merged 6 commits into from
Aug 25, 2022

Conversation

ashin-czi
Copy link
Contributor

Reviewers

Functional: @seve @ambrosejcarr

Readability: @seve @ambrosejcarr


Changes

  • add
  • remove
  • modify
    • Favicon

@ashin-czi ashin-czi changed the title chore: updating Annotate favicon chore: updating Annotate favicon and logo icon Aug 11, 2022
@ashin-czi ashin-czi requested a review from tihuan August 24, 2022 21:52
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice!! Thanks for updating this, Andrew 🙏 !

@ashin-czi ashin-czi marked this pull request as ready for review August 24, 2022 22:26
@ashin-czi
Copy link
Contributor Author

Getting rid of the old html rectangles for the icon and now using the png icon instead:
image

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #2556 (b86305a) into main (c0f4ad6) will not change coverage.
The diff coverage is n/a.

❗ Current head b86305a differs from pull request most recent head c74533b. Consider uploading reports for the commit c74533b to get more accurate results

@@           Coverage Diff           @@
##             main    #2556   +/-   ##
=======================================
  Coverage   71.60%   71.60%           
=======================================
  Files          96       96           
  Lines        6652     6652           
  Branches      770      770           
=======================================
  Hits         4763     4763           
  Misses       1813     1813           
  Partials       76       76           
Flag Coverage Δ
frontend 71.60% <ø> (ø)
javascript 71.60% <ø> (ø)
unitTest 71.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ashin-czi ashin-czi enabled auto-merge (squash) August 25, 2022 15:49
@ashin-czi ashin-czi merged commit 450261f into main Aug 25, 2022
@ashin-czi ashin-czi deleted the ashin-czi/2555-update-logo branch August 25, 2022 16:01
@ashin-czi
Copy link
Contributor Author

Ready for staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants