New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable about this dataset
links
#907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Thanks for getting this in so quickly! One tiny thing I'd change is the info button link from Title Case to just Sentence case (make "this" and "dataset" lowercase, but keep "About" capitalized).
Should note that I haven't added any styles and haven't put much thought into the icon for the menu item. I'm open to any suggestion for the two. |
@bkmartinjr Could you review the server-side of this PR? This is my first time touching that codebase. |
@seve - please fix the build fail (due to lint added to the Python code). See the Travis error output: You can run this on your own box by running the same commands Travis runs. See the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several items I recommend changing:
- fix the lint (build failure)
- change "link" to "url", as that is much more accurate
- (optional) improve the URL validation to check for HTTP scheme
- remove the unused flask template variable
See inline comments.
90af7bf
to
8e182b0
Compare
@@ -41,7 +42,8 @@ class LeftSideBar extends React.Component { | |||
userSelect: "none" | |||
}} | |||
> | |||
cell<span | |||
cell | |||
<span | |||
style={{ | |||
position: "relative", | |||
top: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of this dataset title looks correct, baseline aligned with cellxgene
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this compared to the issue we were seeing in #909?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You marked requesting changed, but not sure what needs changing
@seve - you will need to resolve the merge conflict before this PR can be approved. |
efc07ea
to
d25f3d1
Compare
if this fixes it I have no idea why
745af1c
to
f8c6baa
Compare
This PR introduces configurable link outs to additional information about the dataset. These links are featured conditionally in place of the dataset name in the top-left corner and in the info menu in the top-right.
This PR implements the following changes:
cli/launch.py
--about
flag and descriptionapp/rest_api/rest.py
globals
informationMenu
componentmenubar
componentTopLeftLogoAndTitle
componentThis PR will close #902