Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handle long dataset titles #909

Merged
merged 5 commits into from Sep 23, 2019
Merged

Conversation

seve
Copy link
Member

@seve seve commented Sep 6, 2019

This PR better handles long dataset titles by truncating the middle of the title if the length exceeds 29 characters.

image


This will close #871

@seve
Copy link
Member Author

seve commented Sep 16, 2019

In the case of erratically long dataset titles (e.g. all uppercase W's) I have set it to hide the overflow. To maintain readability, should I implement a tooltip with the full name a la value shortening in #911?

Copy link
Contributor

@colinmegill colinmegill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove magic number 29, move to globals, globals.datasetTitleMaxCharacterCount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handle long dataset titles
3 participants