Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix long values in sidebar #911

Merged
merged 9 commits into from
Oct 2, 2019
Merged

fix long values in sidebar #911

merged 9 commits into from
Oct 2, 2019

Conversation

seve
Copy link
Member

@seve seve commented Sep 6, 2019

This PR fixes the issue with longer values wrapping in the sidebar and creating additional lines. This issue was increased when coloring and adding an occupancy/mini-histogram in the value space.

This is solved by truncating value names by adding ellipses in the center of the value should it be too long. Full value names are still accessible via tooltip.

image


Fixes #891

@seve seve self-assigned this Sep 6, 2019
@seve
Copy link
Member Author

seve commented Sep 6, 2019

@colinmegill @liaprins-czi Not too sure about the tooltip. I currently have the default delay, I think it could be increased to 1s?

@liaprins-czi
Copy link

@seve I know Bruce had just added tooltips to the buttons in the top action bar, so can use the same delay they have?

Copy link

@liaprins-czi liaprins-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good functionality-wise! But I think we need a bit more padding between the end of the name and the start of the sparkline, it is kind of crowded now:
Screen Shot 2019-09-06 at 3 17 10 PM

Is it possible to get as much space between the name and the sparkline as there is between the longest number (on the right end) and the end of the sparkline? Or maybe slide the sparkline over to the right a bit, so there is equal distance?

@seve
Copy link
Member Author

seve commented Sep 9, 2019

I decreased the character threshold for truncating to add more padding between the value name and the sparkline. Also used the global hover delay

@seve
Copy link
Member Author

seve commented Sep 16, 2019

@colinmegill @liaprins-czi bump for reviews

Copy link

@liaprins-czi liaprins-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks Seve!

@colinmegill
Copy link
Contributor

Locally, I'm seeing baseline misalignment for values:

image

@colinmegill
Copy link
Contributor

Also, I would shorten the tooltip delay — too long as is.

@seve
Copy link
Member Author

seve commented Sep 26, 2019

@colinmegill I was able to merge master into this without the extraneous divs, leaving the - 130 instead of - 260. From my light testing, it also fixes #927

@seve
Copy link
Member Author

seve commented Sep 26, 2019

I was reading the conversation in #927 and I may have misunderstood the reasoning behind the change from 160 to 130. Let me know if you want me to switch that back.

@seve seve removed their assignment Sep 30, 2019
@seve seve merged commit f865187 into master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

color-by mode switch changes left side bar layout unecessarily
3 participants