-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix long values in sidebar #911
Conversation
@colinmegill @liaprins-czi Not too sure about the tooltip. I currently have the default delay, I think it could be increased to 1s? |
@seve I know Bruce had just added tooltips to the buttons in the top action bar, so can use the same delay they have? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good functionality-wise! But I think we need a bit more padding between the end of the name and the start of the sparkline, it is kind of crowded now:
Is it possible to get as much space between the name and the sparkline as there is between the longest number (on the right end) and the end of the sparkline? Or maybe slide the sparkline over to the right a bit, so there is equal distance?
I decreased the character threshold for truncating to add more padding between the value name and the sparkline. Also used the global hover delay |
@colinmegill @liaprins-czi bump for reviews |
57caca9
to
970770b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks Seve!
Also, I would shorten the tooltip delay — too long as is. |
@colinmegill I was able to merge master into this without the extraneous divs, leaving the |
I was reading the conversation in #927 and I may have misunderstood the reasoning behind the change from 160 to 130. Let me know if you want me to switch that back. |
This PR fixes the issue with longer values wrapping in the sidebar and creating additional lines. This issue was increased when coloring and adding an occupancy/mini-histogram in the value space.
This is solved by truncating value names by adding ellipses in the center of the value should it be too long. Full value names are still accessible via tooltip.
Fixes #891