Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prototype new struct literal syntax #113

Closed
mlin opened this issue Apr 8, 2019 · 0 comments
Closed

prototype new struct literal syntax #113

mlin opened this issue Apr 8, 2019 · 0 comments
Labels
interop Bears on spec compatibility starter new contributors might start here
Projects
miniwdl
Milestone
WDL 2.0

Comments

@mlin
Copy link
Collaborator

mlin commented Apr 8, 2019 •
edited
Loading

https://github.com/openwdl/wdl/pull/297/files

The salient difference is just that the current object keyword is replaced with the struct type name. This may also permit some refactoring of how we're type-checking the struct literal: we can type-check the contents (check the provided keys and values against the struct type definition) sooner since we know what the intended struct type is.
@mlin mlin created this issue from a note in miniwdl (Backlog) Apr 8, 2019
@mlin mlin added starter new contributors might start here interop Bears on spec compatibility labels May 21, 2019
@mlin mlin moved this from Backlog to Next in miniwdl Feb 3, 2020
@mlin mlin added this to the WDL 2.0 milestone Feb 3, 2020
@mlin mlin moved this from Next to Backlog in miniwdl May 1, 2020
@mlin mlin moved this from Backlog to Next in miniwdl Oct 6, 2020
@mlin mlin moved this from Next to In progress in miniwdl Oct 30, 2020
@mlin mlin mentioned this issue Nov 1, 2020
Merged
mlin added a commit that referenced this issue Nov 1, 2020
@mlin
WDL 2.0 struct literals (#453)
7c1a466 
New struct literal syntax similar to the old `object` syntax, but replaces the `object` keyword with the intended struct type name. This allows earlier static typechecking of the struct members, where before we waited until coercing the object to a struct decl. (The `object` syntax remains valid.)

Some tedious surgery was involved to make declared struct types available to `Expr` typechecking logic, where before they'd only been needed in `Tree`.

#113 openwdl/wdl#297
@mlin mlin moved this from In progress to Pending release in miniwdl Nov 1, 2020
@mlin mlin closed this as completed Nov 3, 2020
miniwdl automation moved this from Pending release to Done Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interop Bears on spec compatibility starter new contributors might start here
Projects
miniwdl
  
Done
Milestone
WDL 2.0
Development

No branches or pull requests
1 participant
@mlin