Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDL 2.0 struct literals #453

Merged
merged 5 commits into from
Nov 1, 2020
Merged

WDL 2.0 struct literals #453

merged 5 commits into from
Nov 1, 2020

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Nov 1, 2020

Implements #113 openwdl/wdl#297

New struct literal syntax similar to the old object syntax, but improves static typechecking by including the intended struct type name in the literal. So we can typecheck the members before later coercing them to a struct declaration/input. (The object syntax still works.)

Some detailed surgery to make declared struct types available to Expr typechecking logic, where before they'd only been needed in Tree.

@coveralls
Copy link

coveralls commented Nov 1, 2020

Pull Request Test Coverage Report for Build 2229

  • 61 of 61 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 96.764%

Totals Coverage Status
Change from base Build 2221: 0.01%
Covered Lines: 6339
Relevant Lines: 6551

💛 - Coveralls

@mlin mlin merged commit 7c1a466 into v0.9.x Nov 1, 2020
@mlin mlin deleted the mlin-new-struct-literals branch November 1, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants