Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out empty support links #1291

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

codemonkey800
Copy link
Collaborator

Description

Fixes issue where links like https://napari-hub.org/plugins/[name] were being clicked on because of an empty value for the documentation link.

Demos

Before

image image

After

image

@codemonkey800 codemonkey800 added the bug-fix Release Label: Used for categorizing bug fixes in automated CI release notes label Oct 26, 2023
Copy link
Collaborator

@manasaV3 manasaV3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemonkey800 codemonkey800 merged commit b22cd74 into main Oct 26, 2023
13 checks passed
@codemonkey800 codemonkey800 deleted the jeremy/filter-out-empty-support-links branch October 26, 2023 19:15
Copy link

This PR has been included in release: v23.10.3, see the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Release Label: Used for categorizing bug fixes in automated CI release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants