Ignore intermittent cloudwatch errors #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
added
the
improvement
richaagarwal
approved these changes
Oct 31, 2023
|
This PR has been included in release: v23.10.3, see the release notes. |
manasaV3
reviewed
Nov 1, 2023
| "-\"CWR: Failed to retrieve Cognito identity\"", | ||
| "-\"CWR: Failed to retrieve credentials\"", | ||
| "-\"CWR: Failed to retrieve Cognito OpenId token\"", |
There was a problem hiding this comment.
Could we generalize this to silence all errors containing the term Cognito or credentials? As we don't want to be alerted on failures of RUM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignores a couple of CWR errors that are safe to ignore because they happen infrequently:
aws-observability/aws-rum-web#227 (comment)
This PR also removes the
The provided "href"error due to it being fixed in #1291