add retry for spdx data #1313
Merged
add retry for spdx data #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
added
the
maintenance
|
let's ignore the E2E tests for now, it seems like another PR is affecting this so will need to investigate |
tihuan
approved these changes
May 8, 2024
There was a problem hiding this comment.
Great refactor, @codemonkey800 👏 LGTM! Just one quick non-blocking comment out of curiosity 😁 Thank you!
| expect(actualRetryCount).toBe(expectedRetryCount); | ||
| }); | ||
|
|
||
| it('should fail when the request fails too many times', async () => { |
There was a problem hiding this comment.
love this test! I was actually checking to see if it throws on error lol
|
This PR has been included in release: v24.05.0, see the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Demos