Adding behavioural tests for API #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manasaV3
requested review from
richaagarwal,
klai95,
codemonkey800 and
DragaDoncila
manasaV3
added
the
improvement
manasaV3
changed the title
| @@ -0,0 +1,74 @@ | |||
| import json | |||
| from behave import given, then | |||
There was a problem hiding this comment.
I think you'll need to add behave to backend/reqiurements.txt
There was a problem hiding this comment.
I hadn't added it there as it was only needed for testing and is not needed at run time. I included it in the setup here instead.
There was a problem hiding this comment.
could you add it to a test requirements file then, in case local users want to test it?
manasaV3
added
new-feature
.github/workflows/deploy.yml
Outdated
| - name: Set workflow artifact file | ||
| run: | | ||
| mkdir -p ./workflow_artifact | ||
| echo STACK_NAME > ./workflow_artifact/stack_name |
There was a problem hiding this comment.
hmm should this be echo $STACK_NAME? otherwise wouldn't this always write STACK_NAME?
There was a problem hiding this comment.
Yes, Thanks for catching that.. :)
.github/workflows/push-rdev.yml
Outdated
| @@ -40,7 +40,10 @@ jobs: | |||
| exit 1 | |||
| else | |||
| echo $GITHUB_REF_NAME | tr '[:upper:]' '[:lower:]' | xargs -I {} -n 1 echo STACK_NAME={} >> $GITHUB_ENV | |||
| mkdir -p ./workflow_artifact | |||
| echo STACK_NAME > ./workflow_artifact/stack_name | |||
There was a problem hiding this comment.
same here should it be echo $STACK_NAME?
codemonkey800
previously approved these changes
Jan 31, 2023
klai95
previously approved these changes
Mar 1, 2023
klai95
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #818
Summary:
Introduces bdd tests for the GET API endpoints that fetch data from s3. It also adds a GitHub workflow to execute the test after a deployment to the dev environment.
To allow the workflow to test the specific dev environment that was deployed to, the push remote dev workflow uploads an artifact of the prefix. The new workflow downloads the artifact and passes that to the behavior tests.