-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to write Plugin manifest to dynamo and s3 #982
Conversation
2801805
to
92aff7a
Compare
92aff7a
to
ca4bcc5
Compare
e6d6e4d
to
25595d9
Compare
25595d9
to
d16d93d
Compare
0d48747
to
424a6c0
Compare
34bd7e1
to
2e5a37d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Co-authored-by: Kira Evans <contact@kne42.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i lack proper context to give this a full review on how the testing/setup is done but overall LGTM. only other thing i might do is assign 'last_updated_timestamp'
to a constant in case you ever foresee that parameter's name getting changed but it's really not necessary
Relates to #862
Description