[feature] Use railtie to load middleware #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldong
changed the base branch from
main
to
stacked_pr/base/donaldong/featur-06b6e74
donaldong
added a commit
that referenced
this pull request
Apr 24, 2021
Pull Request Branch: donaldong/feature_use_railtie_to-1c53203 Pull Request Link: #69
donaldong
force-pushed
the
donaldong/feature_use_railtie_to-1c53203
branch
from
7097dbc
to
2786d34
Compare
donaldong
changed the base branch from
stacked_pr/base/donaldong/featur-06b6e74
to
main
donaldong
added a commit
that referenced
this pull request
Apr 24, 2021
Pull Request Branch: donaldong/feature_use_railtie_to-1c53203 Pull Request Link: #69
donaldong
force-pushed
the
donaldong/feature_use_railtie_to-1c53203
branch
from
2786d34
to
7a8cf42
Compare
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 97.42% 97.43% +0.01%
==========================================
Files 34 36 +2
Lines 2252 2264 +12
==========================================
+ Hits 2194 2206 +12
Misses 58 58
Continue to review full report at Codecov.
|
donaldong
added a commit
that referenced
this pull request
Apr 24, 2021
Pull Request Branch: donaldong/feature_use_railtie_to-1c53203 Pull Request Link: #69
|
also configure the test env db |
donaldong
added a commit
that referenced
this pull request
Apr 24, 2021
Pull Request Branch: donaldong/feature_use_railtie_to-1c53203 Pull Request Link: #69
donaldong
force-pushed
the
donaldong/feature_use_railtie_to-1c53203
branch
from
7a8cf42
to
16c0973
Compare
donaldong
added a commit
that referenced
this pull request
Apr 24, 2021
Pull Request Branch: donaldong/feature_use_railtie_to-1c53203 Pull Request Link: #69
|
fixing spec |
donaldong
added a commit
that referenced
this pull request
Apr 24, 2021
Pull Request Branch: donaldong/feature_use_railtie_to-1c53203 Pull Request Link: #69
donaldong
force-pushed
the
donaldong/feature_use_railtie_to-1c53203
branch
from
16c0973
to
580c3a7
Compare
donaldong
added a commit
that referenced
this pull request
Apr 24, 2021
Pull Request Branch: donaldong/feature_use_railtie_to-1c53203 Pull Request Link: #69
|
fixing spec |
donaldong
added a commit
that referenced
this pull request
Apr 24, 2021
Pull Request Branch: donaldong/feature_use_railtie_to-1c53203 Pull Request Link: #69
donaldong
force-pushed
the
donaldong/feature_use_railtie_to-1c53203
branch
from
580c3a7
to
66243b2
Compare
katyho
approved these changes
Apr 27, 2021
Pull Request Branch: donaldong/feature_use_railtie_to-1c53203 Pull Request Link: #69
donaldong
force-pushed
the
donaldong/feature_use_railtie_to-1c53203
branch
from
66243b2
to
7683985
Compare
Merged
donaldong
added a commit
that referenced
this pull request
Jun 3, 2021
### Breaking Changes - Inline cache validation sample percentage (#78): `config.cache_validation_sampler` is replaced with `config.cache_validation_sample_percentage` - Rename `RedisMemo.without_memo` -> `RedisMemo.without_memoization` (#85) ### Features - Support more queries with range (>=, <= etc) (#63) - Use railtie to load middleware (#69) - Support Ruby 3.x (#83) - Move lua to a separate file, run evalsha after script is already loaded (#84) ### Doc - Update README (#73) - Add options doc (#77) - Add more rdocs for RedisMemo::Batch and RedisMemo::MemoizeMethod (#80) - Add rdocs for RedisMemo::MemoizeQuery (#81) - Add docs for RedisMemo::Memoizable and RedisMemo::Memoizable::Invalidation (#82) - Add rdocs for cache select (#91) - Check in wiki pages (#86) - Check in an example config (#89) ### Refactor - Fix rubocop lint errors (#79) - Move redis-memo specific environment variables into DefaultOptions (#76) - Move errors to a separate file (#72) - Add RedisMemo::Util (#71) - Define ThreadLocalVar (#70)
donaldong
added a commit
that referenced
this pull request
Jun 3, 2021
### Breaking Changes - Inline cache validation sample percentage (#78): `config.cache_validation_sampler` is replaced with `config.cache_validation_sample_percentage` - Rename `RedisMemo.without_memo` -> `RedisMemo.without_memoization` (#85) ### Features - Support more queries with range (>=, <= etc) (#63) - Use railtie to load middleware (#69) - Support Ruby 3.x (#83) - Move lua to a separate file, run evalsha after script is already loaded (#84) ### Doc - Update README (#73) - Add options doc (#77) - Add more rdocs for RedisMemo::Batch and RedisMemo::MemoizeMethod (#80) - Add rdocs for RedisMemo::MemoizeQuery (#81) - Add docs for RedisMemo::Memoizable and RedisMemo::Memoizable::Invalidation (#82) - Add rdocs for cache select (#91) - Check in wiki pages (#86) - Check in an example config (#89) ### Refactor - Fix rubocop lint errors (#79) - Move redis-memo specific environment variables into DefaultOptions (#76) - Move errors to a separate file (#72) - Add RedisMemo::Util (#71) - Define ThreadLocalVar (#70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses railties to load RedisMemo::Middleware. The implementation is identical to https://github.com/steveklabnik/request_store/blob/master/lib/request_store/railtie.rb.
If a project has both RedisMemo and RequestStore configured, RedisMemo and RequestStore middleware will be next to each other. Their relative ordering does not matter much.
Test Plan