[feature] Support Ruby 3.x #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 97.63% 97.64%
=======================================
Files 40 40
Lines 2328 2335 +7
=======================================
+ Hits 2273 2280 +7
Misses 55 55
Continue to review full report at Codecov.
|
donaldong
changed the title
donaldong
force-pushed
the
donaldong/ruby-3
branch
from
71f6b92
to
733a79b
Compare
donaldong
force-pushed
the
donaldong/ruby-3
branch
from
a60bc3a
to
cfff3e8
Compare
katyho
approved these changes
May 26, 2021
Merged
donaldong
added a commit
that referenced
this pull request
Jun 3, 2021
### Breaking Changes - Inline cache validation sample percentage (#78): `config.cache_validation_sampler` is replaced with `config.cache_validation_sample_percentage` - Rename `RedisMemo.without_memo` -> `RedisMemo.without_memoization` (#85) ### Features - Support more queries with range (>=, <= etc) (#63) - Use railtie to load middleware (#69) - Support Ruby 3.x (#83) - Move lua to a separate file, run evalsha after script is already loaded (#84) ### Doc - Update README (#73) - Add options doc (#77) - Add more rdocs for RedisMemo::Batch and RedisMemo::MemoizeMethod (#80) - Add rdocs for RedisMemo::MemoizeQuery (#81) - Add docs for RedisMemo::Memoizable and RedisMemo::Memoizable::Invalidation (#82) - Add rdocs for cache select (#91) - Check in wiki pages (#86) - Check in an example config (#89) ### Refactor - Fix rubocop lint errors (#79) - Move redis-memo specific environment variables into DefaultOptions (#76) - Move errors to a separate file (#72) - Add RedisMemo::Util (#71) - Define ThreadLocalVar (#70)
donaldong
added a commit
that referenced
this pull request
Jun 3, 2021
### Breaking Changes - Inline cache validation sample percentage (#78): `config.cache_validation_sampler` is replaced with `config.cache_validation_sample_percentage` - Rename `RedisMemo.without_memo` -> `RedisMemo.without_memoization` (#85) ### Features - Support more queries with range (>=, <= etc) (#63) - Use railtie to load middleware (#69) - Support Ruby 3.x (#83) - Move lua to a separate file, run evalsha after script is already loaded (#84) ### Doc - Update README (#73) - Add options doc (#77) - Add more rdocs for RedisMemo::Batch and RedisMemo::MemoizeMethod (#80) - Add rdocs for RedisMemo::MemoizeQuery (#81) - Add docs for RedisMemo::Memoizable and RedisMemo::Memoizable::Invalidation (#82) - Add rdocs for cache select (#91) - Check in wiki pages (#86) - Check in an example config (#89) ### Refactor - Fix rubocop lint errors (#79) - Move redis-memo specific environment variables into DefaultOptions (#76) - Move errors to a separate file (#72) - Add RedisMemo::Util (#71) - Define ThreadLocalVar (#70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds Ruby 3 support.
Since there's a Ruby bug https://bugs.ruby-lang.org/issues/10856 in Ruby versions prior to 2.7, I'm dropping support to those versions instead of trying to deal with the bug at runtime.Learn more hereUpdated to use
ruby2_keywordsTest Plan