-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure SQS queues are optional #69
Conversation
Effect : "Allow", | ||
Action : [ | ||
"sqs:SendMessage", | ||
], | ||
Resource : var.sfn_notification_queue_arns | ||
} | ||
} : {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing balks at this empty {}
rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good point...
} | ||
|
||
data "aws_iam_policy_document" "sfn_notifications_topic_policy_document" { | ||
count = length(var.sqs_queues) > 0 ? 1 : 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making a local
var like sqs_queues_enabled = length(var.sqs_queues) > 0
instead of checking length(var.sqs_queue)
all over the place will make this a bit easier to refactor.
Fixes: #64 and #66