Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

[BUG] Adding KPI with incorrect columns does not produce the correct errors #391

Closed
kartikay-bagla opened this issue Nov 11, 2021 · 1 comment
Assignees
Labels
🛠️ backend 🐛 bug Something isn't working

Comments

@kartikay-bagla
Copy link
Contributor

Describe the bug

When selecting a non datetime column as the date column, we get an empty dataframe error instead of an error explaining that the datetime column is not parsable.

@kartikay-bagla kartikay-bagla added 🐛 bug Something isn't working 🛠️ backend labels Nov 11, 2021
@kartikay-bagla kartikay-bagla self-assigned this Nov 11, 2021
@suranah suranah reopened this Nov 12, 2021
@kartikay-bagla
Copy link
Contributor Author

kartikay-bagla commented Nov 12, 2021

So if we accidentally select a double/float/int column as the datetime column, pandas can infer it as unix timestamp (which may be incorrect) and technically passes our datetime columm check. But after that it leads to a SQL error.

How do we want to deal with these type of columns?

@suranah

Fletchersan added a commit that referenced this issue Nov 15, 2021
fix(validation): Closes #391 . Added relevant error message for Datetime columns
RamneekKaur983 added a commit that referenced this issue Nov 15, 2021
Fletchersan added a commit that referenced this issue Nov 15, 2021
fix(validation): Closes #391 .Added relevant error message for Datetime columns
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠️ backend 🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants