Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updating t-2 to t-(k-1) for analytics #523

Merged
merged 1 commit into from
Dec 23, 2021
Merged

feat: updating t-2 to t-(k-1) for analytics #523

merged 1 commit into from
Dec 23, 2021

Conversation

Amatullah
Copy link
Member

  • Changing current implementation where analytics run until t-2 to t-(k-1).
  • k is a configurable global parameter called DAYS_OFFSET_FOR_ANALYTICS, that is set in the .env file.
  • Default value of k=2 i.e. t-2 runs by default.

@netlify
Copy link

netlify bot commented Dec 23, 2021 •
edited

✔️ Deploy Preview for frontend-sb canceled.

🔨 Explore the source changes: 4af359d

🔍 Inspect the deploy log: https://app.netlify.com/sites/frontend-sb/deploys/61c408f1ed7eff0008ccd6cc

suranah
suranah reviewed Dec 23, 2021
View reviewed changes
Copy link
Contributor

@suranah suranah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, would be good for @kartikay-bagla to also review.

@suranah suranah merged commit 9a79fae into main Dec 23, 2021
@Samyak2 Samyak2 deleted the t-minus-k-change branch February 18, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suranah suranah suranah left review comments

@kartikay-bagla kartikay-bagla kartikay-bagla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Amatullah @suranah @kartikay-bagla