Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Druid configurable count column #985

Merged
merged 5 commits into from
Jun 9, 2022
Merged

Conversation

rjdp
Copy link
Contributor

@rjdp rjdp commented Jun 9, 2022

  • add "count_column" to KPI model 80fd1d0
  • add "Update KPI" query to migration script for upgrade instance 80fd1d0
  • read "count_column" from configured value in KPI definition instead of using hardcoded "count" value a318e31
  • add KPI validation to make sure selected count_column is of integer type 40856b2
  • Fixes for the failing pytests because of this change c61ea1e

@rjdp rjdp requested a review from manassolanki June 9, 2022 07:02
@gitpod-io
Copy link

gitpod-io bot commented Jun 9, 2022

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit c61ea1e
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62a1a9edbe02670009696479

@manassolanki
Copy link
Member

LGTM, Just one question, the count column should be ideally visible in case of druid (or similar data source in future). How are we planning to do the same?

@rjdp
Copy link
Contributor Author

rjdp commented Jun 9, 2022

@manassolanki currently its being used only incase when Druid is the datasource ( in KPI add form as well it comes up only when Druid is chosen) , but we plan to use same field when we handle preaggregation usecases across more DBs/DWs

@manassolanki
Copy link
Member

@manassolanki currently its being used only incase when Druid is the datasource ( in KPI add form as well it comes up only when Druid is chosen) , but we plan to use same field when we handle preaggregation usecases across more DBs/DWs

ok, you mean this is hardcode on the frontend side right now.

@rjdp
Copy link
Contributor Author

rjdp commented Jun 9, 2022

@manassolanki it was hardcoded on backend

self._preaggregated_count_col = "count"

@rjdp rjdp merged commit 23e7806 into develop Jun 9, 2022
@Samyak2 Samyak2 added this to the v0.8.0 milestone Jun 10, 2022
@Samyak2 Samyak2 deleted the druid-configurable-count-column branch June 10, 2022 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants