Skip to content

Commit

Permalink
perf: simplify join func (#4434)
Browse files Browse the repository at this point in the history
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
  • Loading branch information
g1eny0ung committed Jun 16, 2024
1 parent 6411f53 commit 700db92
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 2 additions & 1 deletion cmd/generate-makefile/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
// limitations under the License.
//

// This command line tool would generate Makefile like binary.generated.mk, contains targets for building executable binaries.
// This command line tool is used to generate partial Makefiles, such as binary.generated.mk,
// containing targets for building executable binaries.
package main
6 changes: 1 addition & 5 deletions cmd/generate-makefile/funcmaps.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,4 @@ package main

import "strings"

var defaultFuncMap = map[string]interface{}{"StringsJoin": StringsJoin}

func StringsJoin(s []string, sep string) string {
return strings.Join(s, sep)
}
var defaultFuncMap = map[string]interface{}{"StringsJoin": strings.Join}

0 comments on commit 700db92

Please sign in to comment.