Skip to content

Commit

Permalink
feat(helm): allow templating of dashboard rootUrl (#4370)
Browse files Browse the repository at this point in the history
Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
  • Loading branch information
iamKunal and g1eny0ung committed Mar 18, 2024
1 parent 3847f94 commit a10c606
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ For more information and how-to, see [RFC: Keep A Changelog](https://github.com/
- Support for watching remote status of chaos experiments to local [#4188](https://github.com/chaos-mesh/chaos-mesh/pull/4188)
- Add netem/rate support for NetworkChaos [#4017](https://github.com/chaos-mesh/chaos-mesh/pull/4017)
- Support for setting `loadBalancerSourceRanges` in chaos-dashboard service in helm chart [#4172](https://github.com/chaos-mesh/chaos-mesh/pull/4172)
- Helm: allow templating of dashboard rootUrl [#4370](https://github.com/chaos-mesh/chaos-mesh/pull/4370)

### Changed

Expand Down
2 changes: 1 addition & 1 deletion helm/chaos-mesh/templates/chaos-dashboard-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ spec:
- name: DNS_SERVER_CREATE
value: "{{ .Values.dnsServer.create }}"
- name: ROOT_URL
value: "{{ .Values.dashboard.rootUrl }}"
value: "{{ tpl .Values.dashboard.rootUrl . }}"
- name: ENABLE_PROFILING
value: "{{ .Values.enableProfiling }}"
{{- if .Values.dashboard.gcpSecurityMode.existingSecret }}
Expand Down

0 comments on commit a10c606

Please sign in to comment.