feat: use YAML format as experiment description #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 55.78% 47.89% -7.90%
==========================================
Files 68 72 +4
Lines 4383 4320 -63
==========================================
- Hits 2445 2069 -376
- Misses 1768 2042 +274
- Partials 170 209 +39
Continue to review full report at Codecov.
|
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
g1eny0ung
changed the title
g1eny0ung
requested review from
fewdan and
cwen0
and removed request for
fewdan
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
|
Please resolve conflicting files. |
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
cwen0
reviewed
Oct 16, 2020
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
cwen0
reviewed
Oct 16, 2020
| if exp.FinishTime.Add(ttl).Before(nowTime) { | ||
| if err := e.db.Table("archive_experiments").Unscoped().Delete(*exp).Error; err != nil { | ||
| if err := e.db.Table("experiments").Unscoped().Delete(*exp).Error; err != nil { |
There was a problem hiding this comment.
keep archive_experiments as the name of table
…-mesh into feat/yaml-editor
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
|
/merge |
|
/run-all-tests |
|
/run-all-tests |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR aims to use YAML format as an experiment detail in the dashboard.
Motivation:
Usually, we can create or update a chaos experiment by run
kubectl apply -f. But the dashboard isn't, we reorder some spec values into different areas, especially in theupdateeditor. The difficulty is The user will face a very huge JSON structure, but our documentation doesn't explain this (because we use inside the API). And also, to handle different chaos, our update codes add much more conditions and patches which are hard to maintain.So to solve this problem it's better to make the experiment detail structure consistent with the CRD structure.
What is changed and how does it work?
/experiments/detail/:uidto return the same structure as the chaos YAML/experiments/updateto receive the same structure as the chaos YAMLDeleteIncompleteExperiments, call it after fx providers already initialized.Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?