feat: add global search for events, experiments and archives. #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wanyoulc Please sign off DCO first. |
added 2 commits
October 13, 2020 11:16
Signed-off-by: wanyoulc <15694528183@163.com>
Signed-off-by: wanyoulc <15694528183@163.com>
mz921
force-pushed
the
update-global-search
branch
from
e7e247d
to
cf29366
Compare
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
- Coverage 55.78% 47.89% -7.90%
==========================================
Files 68 72 +4
Lines 4383 4320 -63
==========================================
- Hits 2445 2069 -376
- Misses 1768 2042 +274
- Partials 170 209 +39
Continue to review full report at Codecov.
|
Signed-off-by: wanyoulc <15694528183@163.com>
mz921
force-pushed
the
update-global-search
branch
from
0e0728f
to
0a5074a
Compare
…or better readability Signed-off-by: wanyoulc <15694528183@163.com>
g1eny0ung
reviewed
Oct 14, 2020
| const [loading, setLoading] = useState(false) | ||
| const [e, setEvent] = useState<Event | undefined>(undefined) | ||
|
|
||
| const fetchEvent = () => { |
There was a problem hiding this comment.
@fewdan Seems that we need to create an interface to get individual events.
g1eny0ung
requested changes
Oct 14, 2020
|
@wanyoulc And also, the new searching styles don't fit the dark mode. PTAL. |
added 2 commits
October 16, 2020 15:52
…nd better maintainability
add keyboard evnet for triggering search
fix some bugs and details
Signed-off-by: wanyoulc <15694528183@163.com>
…aos-mesh into update-global-search Signed-off-by: wanyoulc <15694528183@163.com>
mz921
force-pushed
the
update-global-search
branch
from
998f35d
to
7ac14fa
Compare
Signed-off-by: wanyoulc <15694528183@163.com>
…aos-mesh into update-global-search
Signed-off-by: wanyoulc <15694528183@163.com>
Signed-off-by: wanyoulc <15694528183@163.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: wanyoulc <15694528183@163.com>
…aos-mesh into update-global-search
add try catch in out of searching process fix some details Signed-off-by: wanyoulc <15694528183@163.com>
mz921
force-pushed
the
update-global-search
branch
from
c7ef76c
to
9accb3c
Compare
Signed-off-by: wanyoulc <15694528183@163.com>
mz921
force-pushed
the
update-global-search
branch
from
9accb3c
to
752b40d
Compare
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
Please resolve the conflict files. @wanyoulc |
|
/run-all-tests |
g1eny0ung
approved these changes
Oct 27, 2020
mz921
added a commit
to mz921/chaos-mesh
that referenced
this pull request
Nov 2, 2020
…mesh#1034) * feat: add global search for events, experiments and archives. Signed-off-by: wanyoulc <15694528183@163.com> Signed-off-by: wanyoulc <15694528183@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR adds a search trigger button, and a global search modal for searching events, experiments, and archives more conveniently.
What is changed and how does it work?
Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?