Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error handling in chaos-dashboard to avoid panic (#1103) #1105

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1103 to release-1.0


What problem does this PR solve?

Accessing certain API interfaces may cause chaos-dashboard panic

What is changed and how does it work?

Exit the function directly when an error is encountered

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: cwen0 <cwenyin0@gmail.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@5f83f95). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-1.0    #1105   +/-   ##
==============================================
  Coverage               ?   48.27%           
==============================================
  Files                  ?       72           
  Lines                  ?     4360           
  Branches               ?        0           
==============================================
  Hits                   ?     2105           
  Misses                 ?     2046           
  Partials               ?      209           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f83f95...c261a85. Read the comment docs.

@cwen0 cwen0 merged commit 1ed0b03 into chaos-mesh:release-1.0 Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard type/bug-fix A bug needs to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants