Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form related bugs in dashboard #1128

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Resolve #1108.

What is changed and how does it work?

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung requested review from cwen0 and mz921 November 2, 2020 08:12
@g1eny0ung g1eny0ung added the type/bug-fix A bug needs to be fixed. label Nov 2, 2020
Copy link
Contributor

@mz921 mz921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Nov 3, 2020

/merge

@ti-srebot
Copy link
Contributor

@cwen0 Oops! This PR requires at least 1 LGTMs to merge. The current number of LGTM is 0

@cwen0 cwen0 merged commit 3b34aab into chaos-mesh:release-1.0 Nov 3, 2020
@g1eny0ung g1eny0ung deleted the fix/form-related-errors branch November 3, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug-fix A bug needs to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants