(Manually cherry-pick) make chaos dashboard be compliable with namespace scoped mode (#1110) #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mesh#1110) * fix(dashboard): make chaos dashboard be compliable with namespace scoped mode Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: tring to make go vet happy Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: update install.sh Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: reformat Signed-off-by: STRRL <str_ruiling@outlook.com> * improvement(dashboard): refine API, only list namespaces which could inject chaos Signed-off-by: STRRL <str_ruiling@outlook.com> * improvement: do not need list namespaces permission anymore Signed-off-by: STRRL <str_ruiling@outlook.com> * fix: append missing permission about list on namespaces within cluster mode Signed-off-by: STRRL <str_ruiling@outlook.com> * fix: change url: from namespaces to chaos-available-namespaces Signed-off-by: STRRL <str_ruiling@outlook.com> * improvement: keeping API: /namespaces and mark it as deprecated Signed-off-by: STRRL <str_ruiling@outlook.com> Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com> Signed-off-by: STRRL <str_ruiling@outlook.com>
|
/run-all-tests |
|
/run-e2e-tests |
|
Hi @g1eny0ung , PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1127 has conflict, manually cherry-pick #1110 to release-1.0.
Here are duplicated code in
pkg/apiserver/experiment/experiment.golike:conf *config.ChaosDashboardConfigis duplicated.Already cleanup manually.