Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support container specified iochaos #1159

Merged
merged 6 commits into from
Nov 11, 2020

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Nov 9, 2020

Signed-off-by: Yang Keao keao.yang@yahoo.com

What problem does this PR solve?

Fix #1156

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

YangKeao commented Nov 9, 2020

/run-e2e-tests

@YangKeao
Copy link
Member Author

YangKeao commented Nov 9, 2020

/run-e2e-tests

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #1159 (62524fb) into master (7e9ff3f) will decrease coverage by 8.49%.
The diff coverage is 26.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
- Coverage   55.78%   47.28%   -8.50%     
==========================================
  Files          68       74       +6     
  Lines        4383     4384       +1     
==========================================
- Hits         2445     2073     -372     
- Misses       1768     2102     +334     
- Partials      170      209      +39     
Impacted Files Coverage Δ
api/v1alpha1/common_types.go 0.00% <0.00%> (ø)
api/v1alpha1/common_validation.go 100.00% <ø> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/dnschaos_type.go 0.00% <0.00%> (ø)
api/v1alpha1/dnschaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/httpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/iochaos_types.go 0.00% <ø> (-40.00%) ⬇️
api/v1alpha1/kernelchaos_types.go 0.00% <ø> (-20.00%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 100.00% <ø> (+14.81%) ⬆️
api/v1alpha1/kinds.go 27.27% <ø> (+0.60%) ⬆️
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc20ce...62524fb. Read the comment docs.

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

YangKeao commented Nov 9, 2020

/run-e2e-tests

cwen0
cwen0 previously approved these changes Nov 11, 2020
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

controllers/podiochaos/types.go Show resolved Hide resolved
controllers/podiochaos/types.go Show resolved Hide resolved
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

/run-e2e-tests

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan fewdan merged commit 173143b into chaos-mesh:master Nov 11, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could IOChaos support container level selection rule
6 participants