-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add networkchaos external targets in dashboard #1168
chore: add networkchaos external targets in dashboard #1168
Conversation
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
==========================================
- Coverage 55.78% 47.28% -8.50%
==========================================
Files 68 74 +6
Lines 4383 4384 +1
==========================================
- Hits 2445 2073 -372
- Misses 1768 2102 +334
- Partials 170 209 +39
Continue to review full report at Codecov.
|
Signed-off-by: Yue Yang g1enyy0ung@gmail.com
What problem does this PR solve?
As the title.
Also, fix some bugs related to
direction
andbandwidth
, PTAL.What is changed and how does it work?
Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?